Update actions versions to Node 20 #94
Conversation
.github/workflows/dist.yml
Outdated
| @@ -123,7 +123,7 @@ jobs: | |||
| RPYBUILD_STRIP_LIBPYTHON: "1" | |||
| RPYBUILD_CC_LAUNCHER: ccache | |||
|
|
|||
| - uses: actions/upload-artifact@v3 | |||
| - uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: "dist-${{ runner.os }}" | |||
There was a problem hiding this comment.
This won't work. This workflow is currently relying on the merging behaviour in artifacts v3.
There was a problem hiding this comment.
Whoops, I saw there was names for each but didn't realize they weren't unique.
There was a problem hiding this comment.
Switching the workflow will also require changing the way docs are built, currently RTD downloads the docs from github actions via https://github.com/robotpy/robotpy-sphinx-plugin/blob/main/robotpy_sphinx/download_and_install.py
There was a problem hiding this comment.
Assuming I did the merging correctly, the artifacts should have the same name and contents, so it looks like that should still work, unless I'm missing something. There are temporary artifacts created, but they are deleted after merging.
There was a problem hiding this comment.
It looks to me like the artifacts are the same as before.
No description provided.